Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the GitHubExtension properly shuts down when CmdPal is closed.
- Added explicit server shutdown and disposal after waiting for the extension to be disposed.
- Ensured that the server is stopped and disposed immediately to prevent lingering processes.
Comments suppressed due to low confidence (1)
GitHubExtension/Program.cs:175
- [nitpick] Verify that using UnsafeDispose is appropriate in this context; if a safer disposal method exists, consider using it to avoid bypassing potential safety checks during shutdown.
server.UnsafeDispose();
guimafelipe
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly close the extension when CmdPal is closed (porting of microsoft/PowerToys#39209)
Note that microsoft/PowerToys#39589 is needed in order to properly close extensions when CmdPal is closed from PowerToys system tray.
Validation steps:
GitHubExtensionprocess is runningGitHubExtensionprocess is closed