Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detection for recommended transport retry configuration #2214

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

richfaj
Copy link
Member

@richfaj richfaj commented Oct 29, 2024

Issue:
PR introduces detection for our recommended retry configuration for Transport service.

Reason:
The default retry interval is too long and can cause longer than expected mail delivery times when a transient error occurs at the SMTP layer.

Our recommended retry configuration is published here: https://aka.ms/TransportRetryConfig

Fix:
Checks to make sure the recommended values are set correctly for

  • MaxPerDomainOutboundConnections
  • MessageRetryInterval

Resolved #2207

Validation:
.\build.ps1

@dpaulson45
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@dpaulson45 dpaulson45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work for first time contribution! Just very minor things that I would like to see changed.

@richfaj richfaj marked this pull request as ready for review October 30, 2024 21:03
@richfaj richfaj requested a review from a team as a code owner October 30, 2024 21:03
@dpaulson45
Copy link
Member

/azp run

@dpaulson45 dpaulson45 self-requested a review October 30, 2024 21:29
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dpaulson45
Copy link
Member

Let's also squash all the commits down to 1 here.

@richfaj
Copy link
Member Author

richfaj commented Oct 31, 2024

Let's also squash all the commits down to 1 here.

Done.

@dpaulson45
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dpaulson45 dpaulson45 self-requested a review November 4, 2024 20:37
@dpaulson45 dpaulson45 merged commit 43c3921 into microsoft:main Nov 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for recommended Transport retry interval config
2 participants