-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detection for recommended transport retry configuration #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
dpaulson45
reviewed
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work for first time contribution! Just very minor things that I would like to see changed.
Diagnostics/HealthChecker/DataCollection/ExchangeInformation/Get-ExchangeInformation.ps1
Outdated
Show resolved
Hide resolved
Diagnostics/HealthChecker/DataCollection/ExchangeInformation/Get-ExchangeInformation.ps1
Outdated
Show resolved
Hide resolved
Diagnostics/HealthChecker/Analyzer/Invoke-AnalyzerFrequentConfigurationIssues.ps1
Outdated
Show resolved
Hide resolved
Diagnostics/HealthChecker/Analyzer/Invoke-AnalyzerFrequentConfigurationIssues.ps1
Outdated
Show resolved
Hide resolved
Diagnostics/HealthChecker/Analyzer/Invoke-AnalyzerFrequentConfigurationIssues.ps1
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
dpaulson45
reviewed
Oct 30, 2024
Diagnostics/HealthChecker/DataCollection/ExchangeInformation/Get-ExchangeInformation.ps1
Outdated
Show resolved
Hide resolved
Let's also squash all the commits down to 1 here. |
richfaj
force-pushed
the
RetryConfigCheck
branch
from
October 31, 2024 17:18
af322ba
to
6f99735
Compare
Done. |
dpaulson45
reviewed
Nov 4, 2024
Diagnostics/HealthChecker/Analyzer/Invoke-AnalyzerFrequentConfigurationIssues.ps1
Outdated
Show resolved
Hide resolved
richfaj
force-pushed
the
RetryConfigCheck
branch
from
November 4, 2024 20:24
47e9c92
to
642bc9e
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
dpaulson45
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
PR introduces detection for our recommended retry configuration for Transport service.
Reason:
The default retry interval is too long and can cause longer than expected mail delivery times when a transient error occurs at the SMTP layer.
Our recommended retry configuration is published here: https://aka.ms/TransportRetryConfig
Fix:
Checks to make sure the recommended values are set correctly for
Resolved #2207
Validation:
.\build.ps1