first version bookings Helper #2197
Conversation
Only comment would be if you wanted to rename from RunMessageTrackingLogTests to RunMessageTrackingLogValidation Refers to: Calendar/BookingHelpers/BookingMessageTrackingLogLogic.ps1:1 in 204f797. [](commit_id = 204f797, deletion_comment = False) |
|
@microsoft-github-policy-service agree company="Microsoft" |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| $BookingBusinessArray += [PSCustomObject]@{ | ||
| DisplayName = $GraphBookingBusiness.DisplayName | ||
| OwnerEmail = $GraphBookingBusiness.Email | ||
| IsPublished = $GraphBookingBusiness.IsPublished | ||
| DefaultCurrencyIso = $GraphBookingBusiness.DefaultCurrencyIso | ||
| DefaultTimeZone = $GraphBookingBusiness.DefaultTimeZone | ||
| LanguageTag = $GraphBookingBusiness.LanguageTag | ||
| Phone = $GraphBookingBusiness.Phone | ||
| PublicUrl = $GraphBookingBusiness.PublicUrl | ||
| WebSiteUrl = $GraphBookingBusiness.WebSiteUrl | ||
| CreatedDateTime = $GraphBookingBusiness.AdditionalProperties["createdDateTime"] | ||
| lastUpdatedDateTime = $GraphBookingBusiness.AdditionalProperties["lastUpdatedDateTime"] | ||
| Address = "City= " + $GraphBookingBusiness.Address.City + ", `r`n" + | ||
| "CountryOrRegion= " + $GraphBookingBusiness.Address.CountryOrRegion + ", `r`n" + | ||
| "PostalCode= " + $GraphBookingBusiness.Address.PostalCode + ", `r`n" + | ||
| "State= " + $GraphBookingBusiness.Address.State + ", `r`n" + | ||
| "Street= " + $GraphBookingBusiness.Address.Street | ||
| } |
There was a problem hiding this comment.
Shouldn't this be inside a loop? If you want the type to be returned an array, we should be able to create the object and define the type we want to be returned.
There was a problem hiding this comment.
Not in this case, this method returns a 1 element array to be imported to Excel
There was a problem hiding this comment.
Then we shouldn't be doing a += to make it an array element. Use the casting of [array] if that is what you want.
| if ($PSCmdlet.ShouldProcess('Microsoft.Graph.Bookings module', 'Import')) { | ||
| Write-Verbose "Installing Microsoft.Graph.Bookings module..." | ||
|
|
||
| # Install Microsoft.Graph.Bookings module | ||
| Install-Module -Name Microsoft.Graph.Bookings -Force -AllowClobber | ||
|
|
||
| Write-Host "Done. Microsoft.Graph.Bookings module is now installed. Please re-run the script." |
There was a problem hiding this comment.
I agree that we need to likely do this. However, we should place it in Share somehow to avoid other scripts doing this same thing over and over again.
Need to think about this.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Please add CSS-Exchange/.build/cspell-words.txt Line 124 in a6be221 |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Issue:
Describe what the issue is you are addressing
Reason:
Describe what the reason is for making the change
Fix:
Short description of the fix
Validation:
Provide if applicable