Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix x-ms-request-id header null reference #381

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix x-ms-request-id header null reference #381

wants to merge 4 commits into from
+69 −2

Commits on Aug 7, 2024

  1. fix: Check that x-ms-request-id header exists before accessing value. 

    If no value is found, getFirstHeader returns null. Accessing getValue throws an error.
    Scott Kearney committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    2f2a7f5 View commit details
    Browse the repository at this point in the history

  2. fix: Check that x-ms-request-id header exists before accessing value. 

    If no value is found, GetValues returns null. Accessing FirstOrDefault throws an error.
    Scott Kearney committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    65652de View commit details
    Browse the repository at this point in the history

  3. fix: Add Moq package to Tests project 

    Moq is referenced in the code, but wasn't defined as a package for the project.
    Scott Kearney committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    d889a07 View commit details
    Browse the repository at this point in the history

  4. test: Add test for HttpClient to address newly-fixed functionality. 

    Test should run successfully when the x-ms-request-id header null reference is fixed.
    Scott Kearney committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    2576032 View commit details
    Browse the repository at this point in the history