Add TLAi linter. #6098
Merged
Add TLAi linter. #6098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mku-tlai@83226 aka 20240326.30 vs main ewma over 20 builds from 82798 to 83199 Click to see tablemain
mku-tlai
|
achamayou
approved these changes
Mar 26, 2024
|
The script seems to run but the upload to SARIF fails: https://github.com/microsoft/CCF/actions/runs/8442480667/job/23123973469
It sounds like github/codeql-action#2117, but the repo is definitely public, so perhaps not? |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -20,7 +20,8 @@ | |||
| SerialiseCoverageConstraint == | |||
| LET interval == 500000 | |||
| IN IF TLCGet("distinct") % interval = 0 | |||
| THEN Serialize(<<TLCGet("spec")>>, CoverageFilename, [format |-> "NDJSON", charset |-> "UTF-8", openOptions |-> <<"WRITE", "CREATE", "APPEND">>]) | |||
| THEN /\ Serialize(<<TLCGet("spec")>>, CoverageFilename, [format |-> "NDJSON", charset |-> "UTF-8", openOptions |-> <<"WRITE", "CREATE", "APPEND">>]) | |||
Check warning
Code scanning / genaiscript
TLAi-linter Warning
tla/StatsFile.tla
Outdated
| @@ -20,7 +20,8 @@ | |||
| SerialiseCoverageConstraint == | |||
| LET interval == 500000 | |||
| IN IF TLCGet("distinct") % interval = 0 | |||
| THEN Serialize(<<TLCGet("spec")>>, CoverageFilename, [format |-> "NDJSON", charset |-> "UTF-8", openOptions |-> <<"WRITE", "CREATE", "APPEND">>]) | |||
| THEN /\ Serialize(<<TLCGet("spec")>>, CoverageFilename, [format |-> "NDJSON", charset |-> "UTF-8", openOptions |-> <<"WRITE", "CREATE", "APPEND">>]) | |||
| /\ PrintT("Writing stats to file: " \o CoverageFilename) | |||
Check notice
Code scanning / genaiscript
TLAi-linter
| @@ -20,7 +20,8 @@ | |||
| SerialiseCoverageConstraint == | |||
| LET interval == 500000 | |||
| IN IF TLCGet("distinct") % interval = 0 | |||
| THEN Serialize(<<TLCGet("spec")>>, CoverageFilename, [format |-> "NDJSON", charset |-> "UTF-8", openOptions |-> <<"WRITE", "CREATE", "APPEND">>]) | |||
| THEN /\ Serialize(<<TLCGet("spec")>>, CoverageFilename, [format |-> "NDJSON", charset |-> "UTF-8", openOptions |-> <<"WRITE", "CREATE", "APPEND">>]) | |||
Check failure
Code scanning / genaiscript
TLAi-linter Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% certain that this automation will have always access to the env secrets. Unfortunately, I don't know how to check it without deploying it.