Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

build: add typechecking to extension build script #9494

Merged
a-b-r-o-w-n merged 5 commits into from
Jan 25, 2023
Merged

build: add typechecking to extension build script #9494

a-b-r-o-w-n merged 5 commits into from
Jan 25, 2023

Conversation

@a-b-r-o-w-n
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n commented Jan 25, 2023

Description

Adds a typechecking step when building extensions to guard against type changes during package upgrades, etc.

Task Item

#minor

Screenshots

@coveralls
Copy link

coveralls commented Jan 25, 2023 •
edited
Loading

Coverage Status

Coverage: 54.564%. Remained the same when pulling 6f28d27 on abrown/extension-type-check into 7455bae on main.

@a-b-r-o-w-n
Copy link
Contributor Author

a-b-r-o-w-n commented Jan 25, 2023

Note: this should start failing the build due to existing type errors in the extensions. The plan is to merge this to main so that future compile errors are caught.

tdurnford
tdurnford previously approved these changes Jan 25, 2023
View reviewed changes
tdurnford
tdurnford previously approved these changes Jan 25, 2023
View reviewed changes
@a-b-r-o-w-n a-b-r-o-w-n merged commit 77255fb into main Jan 25, 2023
@a-b-r-o-w-n a-b-r-o-w-n deleted the abrown/extension-type-check branch January 25, 2023 20:53
@cwhitten cwhitten mentioned this pull request Aug 15, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@tdurnford tdurnford tdurnford left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tdurnford tdurnford

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@a-b-r-o-w-n @coveralls @tdurnford