This repository was archived by the owner on Jul 9, 2025. It is now read-only.
chore: update fluent to v 8.83 #9319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OEvgeny
requested review from
VamsiModem,
a-b-r-o-w-n,
benbrown,
beyackle,
boydc2014,
cwhitten,
natalgar,
srinaath,
tdurnford and
tonyanziano
as code owners
tonyanziano
suggested changes
Jul 26, 2022
Contributor
tonyanziano
left a comment
tonyanziano
left a comment
There was a problem hiding this comment.
I think the fluent upgrade must have broken a few tests.
The Manage___ tests are flaky and it's ok if they break, but there were 7 tests that failed. The last PR to go in succeeded on all the checks so I think it's worth investigating.
OEvgeny
force-pushed
the
chore/update-fluent-2
branch
from
96ba1a3 to
b97dffd
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue with tables sorting not being announced.
Fluent team did some changes in response to the issue we have, so this updates fluent version and adds required aria attributes to tables to address the issue.
Task Item
VSTS-69832
Screenshots
#minor