Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@BruceHaley
Copy link
Contributor

@BruceHaley BruceHaley commented Jul 7, 2022

Fixes #minor

Changes

  1. Update yarn from 3.1.1 to 3.2.1. Needed for #⁠2. See .cjs files
  2. Add up-all plugin. Allows updating dependencies with exclusions. Needed for #⁠3. See yarn-up-all-plugin.cjs
  3. Add "Update Composer dependencies" github workflow. Extensions dependencies updating is complex enough that automation is left for a later PR.
  4. Update dependencies for Composer and for extensions. See package.json and yarn-berry.lock files.
  5. Fix eslint lodash/path-style errors. Change these errors to warnings. See Composer/.eslintrc.js.
  6. Fix eslint security/detect-unsafe-regex errors. Disable this rule at specific lines. See .ts files.
  7. Tweak azure-pipelines.yml for readability.

@BruceHaley BruceHaley changed the title Experimental dependency updates from yarnupall7-6e chore: Experimental dependency updates from yarnupall7-6e Jul 7, 2022
@coveralls
Copy link

coveralls commented Jul 8, 2022

Coverage Status

Coverage remained the same at 54.547% when pulling 07ac795 on bruce/yarnuptest7-6e into d1789e4 on main.

@BruceHaley BruceHaley marked this pull request as ready for review July 8, 2022 22:43
@BruceHaley BruceHaley changed the title chore: Experimental dependency updates from yarnupall7-6e chore: Update dependencies for Composer and extensions Jul 8, 2022
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, going to wait for E2E to run and then locally test the windows and linux builds to make sure there are no obvious issues.

@@ -0,0 +1,26 @@
name: Update Composer dependencies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@tonyanziano
Copy link
Contributor

Looks like all the tests are passing, it's only failing on the security alerts which will eventually be fixed as a result of this PR. Going to check the production apps built from your branch.

Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the mock build on all 3 platforms. Looks good!

@tonyanziano tonyanziano merged commit 50c2e2b into main Jul 14, 2022
@tonyanziano tonyanziano deleted the bruce/yarnuptest7-6e branch July 14, 2022 20:15
@cwhitten cwhitten mentioned this pull request Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants