Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

chore: use yarn 3 for development #9201

Merged
tonyanziano merged 22 commits into from
Jun 22, 2022
Merged

chore: use yarn 3 for development #9201

tonyanziano merged 22 commits into from
Jun 22, 2022

Conversation

@OEvgeny
Copy link
Collaborator

@OEvgeny OEvgeny commented May 20, 2022 •
edited
Loading

Description

  • Cleanup scripts
  • Fix linux specific issue with @microsoft/orchestrator-core not being built
  • Split .yarnrc.yml files for dev and prod, so prod could use Azure registry
  • Update yarn-berry lockfiles
  • Remove old yarn lockfiles
  • Switch PR CI to yarn@3

#minor

@OEvgeny
chore: use yarn 3 for development
607ec59 
* Cleanup scripts
* Fix linux specific issue with `@microsoft/orchestrator-core` not being built
* Split `.yarnrc.yml` files for dev and prod, so prod could use Azure registry
* Update yarn-berry lockfiles
* Remove old yarn lockfiles
@OEvgeny OEvgeny force-pushed the chore/update-yarn-dev branch 3 times, most recently from b81196a to e69b334 Compare May 20, 2022 19:53
@OEvgeny OEvgeny force-pushed the chore/update-yarn-dev branch from e69b334 to 92642cb Compare May 20, 2022 20:15
tonyanziano
tonyanziano reviewed May 20, 2022
View reviewed changes
@OEvgeny OEvgeny force-pushed the chore/update-yarn-dev branch from be95dc1 to b91417f Compare May 20, 2022 20:51
@coveralls
Copy link

coveralls commented May 20, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-1.3%) to 54.547% when pulling bba005e on OEvgeny:chore/update-yarn-dev into 7df3a17 on microsoft:main.

@OEvgeny OEvgeny force-pushed the chore/update-yarn-dev branch from 537cbd6 to 35f8c11 Compare May 27, 2022 17:56
@OEvgeny OEvgeny requested a review from tonyanziano June 9, 2022 17:59
tonyanziano
tonyanziano previously approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor comments, otherwise it looks good 👍

Composer/packages/client/src/recoilModel/dispatchers/provisionQNA.ts
import { TokenCredentials } from '@azure/ms-rest-js';
import { SearchManagementClient } from '@azure/arm-search';
import { SkuName } from '@azure/arm-search/lib/models';
import { SkuName } from '@azure/arm-search/esm/models';
Copy link
Contributor

@tonyanziano tonyanziano Jun 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious: why was this changed?

Copy link
Collaborator Author

@OEvgeny OEvgeny Jun 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I recall yarn 3 resolved packages a bit differently and in the newer package types moved to esm folder

@tonyanziano
Copy link
Contributor

tonyanziano commented Jun 9, 2022

Looks like the most recent unit test run failed:

Summary of all failing tests
FAIL packages/lib/code-editor/src/components/toolbar/tests/ToolbarButtonMenu.test.tsx
● › property: Should render icon button with properties in menu when passed property payload
TestingLibraryElementError: Unable to find an element with the text: /this/. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

@OEvgeny
Copy link
Collaborator Author

OEvgeny commented Jun 9, 2022 •
edited
Loading

I believe worker died. Let's see if it passes

@OEvgeny OEvgeny requested a review from tonyanziano June 10, 2022 17:42
@tonyanziano tonyanziano merged commit 6325ad2 into microsoft:main Jun 22, 2022
@OEvgeny OEvgeny deleted the chore/update-yarn-dev branch June 22, 2022 21:16
@cwhitten cwhitten mentioned this pull request Aug 15, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@natalgar natalgar Awaiting requested review from natalgar

@VamsiModem VamsiModem Awaiting requested review from VamsiModem

@benbrown benbrown Awaiting requested review from benbrown

@cwhitten cwhitten Awaiting requested review from cwhitten

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@beyackle beyackle Awaiting requested review from beyackle

@srinaath srinaath Awaiting requested review from srinaath

@tdurnford tdurnford Awaiting requested review from tdurnford

1 more reviewer

@tonyanziano tonyanziano tonyanziano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@OEvgeny @coveralls @tonyanziano