This repository was archived by the owner on Jul 9, 2025. It is now read-only.
chore: upgrade webchat and emotion #9150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OEvgeny
force-pushed
the
a11y/webchat
branch
3 times, most recently
from
5e6900f to
7667a35
Compare
OEvgeny
requested review from
VamsiModem,
a-b-r-o-w-n,
benbrown,
beyackle,
boydc2014,
cwhitten,
natalgar,
srinaath,
tdurnford and
tonyanziano
as code owners
* Upgrade WebChat packages to fix accessibility issues * Upgrade emotion due to WebChat emotion bump * Refactor codebase to meet `emotion@11` requirements * Include required types for tsc to pass type checks
OEvgeny
commented
May 18, 2022
| import React, { ReactNode } from 'react'; | ||
|
|
||
| interface OffsetContainerProps { | ||
| interface OffsetContainerProps extends React.HTMLAttributes<HTMLElement> { |
Collaborator
Author
There was a problem hiding this comment.
Since v11 emotion removed css property from component props. See here: https://github.dev/emotion-js/emotion/blob/71ca9be3368ddb0a95ef5b2db7a97c67ab440593/packages/react/types/jsx-namespace.d.ts#L33
There are workarounds for turning it on for all components globally, but all of them assume either react@17 or babel transform or a single tsconfig.json.
So, adding generic html element props directly to the props interface seems like a best fix for the issue at this point
tonyanziano
approved these changes
May 19, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
emotion@11requirements#minor