This repository was archived by the owner on Jul 9, 2025. It is now read-only.
chore: update electron to currently supported version #9053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OEvgeny
changed the title
OEvgeny
requested review from
VamsiModem,
a-b-r-o-w-n,
benbrown,
beyackle,
boydc2014,
cwhitten,
natalgar,
srinaath,
tdurnford and
tonyanziano
as code owners
OEvgeny
commented
Mar 16, 2022
OEvgeny
commented
Mar 16, 2022
tonyanziano
reviewed
Mar 16, 2022
OEvgeny
commented
Mar 16, 2022
tonyanziano
previously approved these changes
Mar 17, 2022
Contributor
tonyanziano
left a comment
tonyanziano
left a comment
There was a problem hiding this comment.
This looks good to me. Since this deals with Electron which could potentially impact our packaging process, I'd like to test some builds on this branch before I merge it.
OEvgeny
force-pushed
the
chore/update-electron
branch
from
fe666da to
fcca56d
Compare
tonyanziano
previously approved these changes
May 16, 2022
tonyanziano
approved these changes
May 17, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Electron so it can apply high contrast theme
Task Item
Screenshots
#minor