This repository was archived by the owner on Jul 9, 2025. It is now read-only.
a11y: improve bot controller keyboard handling #9014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the following issues - Focus stucks on bot controller menu when navigating with keyboard - Focus doesn't get to the opened debug panel when navigating to run details - No region aria provided for debug pane The following changes were made to address these issues: - Replace Callout component with FocusTrapCallout to handle focus inside the menu correctly - Add an effect to place focus to the debug panel when panel gets opened - Configure FocusTrapCallout to allow focusing elements outside of the callout - Add requred aria attirbutes to the debug panel root
OEvgeny
requested review from
VamsiModem,
a-b-r-o-w-n,
benbrown,
beyackle,
boydc2014,
cwhitten,
natalgar,
srinaath,
tdurnford and
tonyanziano
as code owners
tonyanziano
approved these changes
Mar 2, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the following issues
The following changes were made to address these issues:
Task Item
Screenshots
#minor