This repository was archived by the owner on Jul 9, 2025. It is now read-only.
a11y: handle keyboard navigation in array fields #8998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the following issues found for ArrayField: - The field disappears when moving focus back via keyboard (shift+tab) - No chance to know current row when a field gets active - Unclear focus behavior when pressing "Add new" button: focus stays on the button - Multiple fields have the same id The PR introduces the following changes to fix issues above: - Remove field removal on blur because it works unstable. Instead disable "Add new" button until the previous field recieves the value, and remove any empty field in-between fields with values when adding a new empty field - Add a `region` role to array fields with clear `aria-label` and make the region focusable - Place focus on the region when creating a new field via keyboard (focus is not visible when clicking "Add new" via mouse) - Add an index to array field ids, so every field has a different id
OEvgeny
requested review from
VamsiModem,
a-b-r-o-w-n,
benbrown,
beyackle,
boydc2014,
cwhitten,
natalgar,
srinaath,
tdurnford and
tonyanziano
as code owners
tonyanziano
approved these changes
Feb 18, 2022
Contributor
tonyanziano
left a comment
tonyanziano
left a comment
There was a problem hiding this comment.
I had only one comment, but other than that it looks great 👍
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the following issues found for ArrayField:
The PR introduces the following changes to fix issues above:
regionrole to array fields with cleararia-labeland make the region focusableTask Item
Screenshots
#minor