Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@OEvgeny
Copy link
Collaborator

@OEvgeny OEvgeny commented Feb 10, 2022

Description

Fixed the following issues with Settings controls:

  • Make Bot allowed caller controls more descriptive so screen reader users can distinguish controls from different rows
  • Fix empty label for the Channels publishing profile dropdown
  • Fix keyboard interactions for the Channels publishing profiles dropdown

Task Item

Screenshots

image
image

#minor

Fixed the following issues with Settings controls:
- Make Bot allowed caller controls more descriptive so screen reader users can distinguish controls from different rows
- Fix empty label for the Channels publishing profile dropdown
- Fix keyboard interractions for the Channels publishing profiles dropdown
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, nice work!

@tonyanziano tonyanziano merged commit aaa7ee0 into microsoft:main Feb 10, 2022
@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 55.957% when pulling 4ce8750 on OEvgeny:a11y/settings-aria-name into 7965282 on microsoft:main.

@OEvgeny OEvgeny deleted the a11y/settings-aria-name branch February 10, 2022 21:31
@cwhitten cwhitten mentioned this pull request Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants