This repository was archived by the owner on Jul 9, 2025. It is now read-only.
a11y: make Select Dialog to be a listbox with options #8976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR improves the button role by making the control to appear as a listbox with options which is closer to the control functionality.
OEvgeny
requested review from
VamsiModem,
a-b-r-o-w-n,
benbrown,
beyackle,
boydc2014,
cwhitten,
natalgar,
srinaath,
tdurnford and
tonyanziano
as code owners
tonyanziano
suggested changes
Feb 8, 2022
Contributor
tonyanziano
left a comment
tonyanziano
left a comment
There was a problem hiding this comment.
The change looks good, but it looks like the selectDialog.test.tsx is failing:
Summary of all failing tests
FAIL packages/ui-plugins/select-dialog/src/__tests__/selectDialog.test.tsx (6.263 s)
● Select Dialog › should create a new dialog
TestingLibraryElementError: Unable to find an accessible element with the role "menuitem"
Here are the accessible roles:
listbox:
Collaborator
Author
|
Updated, thanks for looking into this! |
cwhitten
approved these changes
Feb 9, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR improves the button role by making the control to appear as a listbox with options which is closer to the control functionality.
Task Item
Screenshots
#minor