Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@zhixzhan
Copy link
Contributor

Description

set breadcrumb width to (85%, 15%), introduced in #7720

Task Item

close #8361

Screenshots

@cypress
Copy link

cypress bot commented Jul 14, 2021



Test summary

16 0 1 0Flakiness 0


Run details

Project Composer
Status Passed
Commit 17e751c
Started Jul 15, 2021 9:23 PM
Ended Jul 15, 2021 9:28 PM
Duration 05:32 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@coveralls
Copy link

coveralls commented Jul 14, 2021

Coverage Status

Coverage decreased (-0.02%) to 55.739% when pulling 17e751c on zhixzhan/resizing-fix into 586ec15 on main.

@srinaath
Copy link
Contributor

@zhixzhan were you able to repro the ResizeObserver Loop error and after the PR did the issue stop surfacing?

I think it still makes sense to merge the PR as we dont need to set the breadcrumb width through JS and we can take these changes in @sorgh @boydc2014

@hatpick
Copy link
Contributor

hatpick commented Jul 14, 2021

Do you have a solid repro for the issue? @zhixzhan
if using percentage width (which was both me and Srinaath recommendation in the first place) solves the original issue, please go with it, it's better than manual calculations in JS.

@beyackle
Copy link
Contributor

I agree with the above - if this does solve the ResizeObserver issue, it should be approved and merged. I'm having trouble reproing the original bug, though, so it's hard for me to know whether this does or not.

@zhixzhan
Copy link
Contributor Author

@srinaath @hatpick @beyackle I can not repro this bug, after removing JS calculation, UI is still looks good, and should also improve page performance.

@srinaath srinaath merged commit 5755ec3 into main Jul 15, 2021
@srinaath srinaath deleted the zhixzhan/resizing-fix branch July 15, 2021 23:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[R14 bugbash] Resizing the Composer window gets ResizeObserver loop limit exceeded

6 participants