This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feat: Debug panel feature updates #8141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
srinaath
changed the title
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
4 tasks
hatpick
reviewed
Jun 21, 2021
Composer/packages/client/src/components/BotRuntimeController/BotController.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/DropdownWithAllOption/DropdownWithAllOption.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/DropdownWithAllOption/DropdownWithAllOption.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/DropdownWithAllOption/DropdownWithAllOption.tsx
Outdated
Show resolved
Hide resolved
| super(rootProjectId, projectId, id, location, diagnostic); | ||
| this.dialogPath = this.findDialogPath(luFile, dialogs, diagnostic); | ||
| const friendlyPath = getFriendlyPath(this.dialogPath, dialogs); | ||
| if (friendlyPath.length) { |
Contributor
There was a problem hiding this comment.
does it matter if it's set to an empty [] vs. being undefined
Contributor
Author
There was a problem hiding this comment.
In both the cases we would just display the location property. (non friendly one)
...ckages/client/src/pages/design/DebugPanel/TabExtensions/DiagnosticsTab/DiagnosticsStatus.tsx
Outdated
Show resolved
Hide resolved
...es/client/src/pages/design/DebugPanel/TabExtensions/DiagnosticsTab/DiagnosticsTabContent.tsx
Outdated
Show resolved
Hide resolved
...es/client/src/pages/design/DebugPanel/TabExtensions/DiagnosticsTab/DiagnosticsTabContent.tsx
Outdated
Show resolved
Hide resolved
...r/packages/client/src/pages/design/DebugPanel/TabExtensions/WebChatLog/WebChatLogContent.tsx
Outdated
Show resolved
Hide resolved
added 2 commits
June 21, 2021 16:44
1. Addressed callback naming 2. Used severity enum 3. Updating Warning colors Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
added 4 commits
June 22, 2021 13:31
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Check if integration tests work Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
srinaath
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
benbrown,
beyackle,
boydc2014,
cwhitten,
pavolum,
tdurnford and
tonyanziano
as code owners
cwhitten
approved these changes
Jun 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fit and Finish items for DebugPanel
Task Item
Fixes #7984, #8032
Screenshots