Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@pavolum
Copy link
Contributor

@pavolum pavolum commented May 21, 2021

Description

Issue

  • Hash routing does not work with multi bot templates due to hash lost in redirects.
  • We should use recoil state for things like detecting if panes are open or not

Solution
-Move teachingbubble render state to recoil and respective calls to manage that new state value

Task Item

fixes #7734

@pavolum pavolum merged commit dbeb752 into pavolum/r14_stage May 21, 2021
@pavolum pavolum deleted the pavolum/luisTeachingCallOutFix branch May 21, 2021 20:50
benbrown pushed a commit to benbrown/BotFramework-Composer that referenced this pull request May 24, 2021
…oft#7884)

* -Adding getstarted teach bubble to app state
-creating a dispatcher for it

* setting state value to show teaching bubble as opposed to hash routing

* adding onclick state changing to manage state for teaching button dismisal
@pavolum pavolum restored the pavolum/luisTeachingCallOutFix branch June 3, 2021 18:41
benbrown pushed a commit that referenced this pull request Jun 11, 2021
* -Adding getstarted teach bubble to app state
-creating a dispatcher for it

* setting state value to show teaching bubble as opposed to hash routing

* adding onclick state changing to manage state for teaching button dismisal
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants