Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: exclude items from the package manager list that do not have names #7683

Merged
cwhitten merged 2 commits into from
May 7, 2021
Merged

fix: exclude items from the package manager list that do not have names #7683

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ea40e8
exclude items from the package manager list that do not have names or…
benbrown May 6, 2021
338210d
Merge branch 'main' into benbrown/localcomponents
benbrown May 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/packageManager/src/node/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const hasSchema = (c) => {
};

const isAdaptiveComponent = (c) => {
return hasSchema(c) || c.includesExports;
return c.name && c.version && (hasSchema(c) || c.includesExports);
Copy link
Member

@GeoffCoxMSFT GeoffCoxMSFT May 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit - you could do c?.name to handle c being undefined since c doesn't have any type, but since this is internal you can protect it from the caller.

};

const readFileAsync = async (path, encoding) => {
Expand Down