This repository was archived by the owner on Jul 9, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 374
fix: Update provision & publishing copy (#7583) #7642
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
265c677
Issue-7583: update copy for provision and publishing
natalgar e3f7eb9
en-us json files
natalgar 043bcde
Merge remote-tracking branch 'origin' into natalgar/7583-update-provi…
natalgar af8c664
Merge remote-tracking branch 'origin' into natalgar/7583-update-provi…
natalgar b39c192
Issue-7583: fix formatDialogTitle
natalgar 19ef557
Merge remote-tracking branch 'origin' into natalgar/7583-update-provi…
natalgar 9115a7c
Issue-7583: refactor formatDialogTitle
natalgar 8bab999
Issue-7583: reformat azure provision dialog block
natalgar 792a9a9
PR fixes
GeoffCoxMSFT f908c95
Fixed spacing
GeoffCoxMSFT File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,6 +38,17 @@ const Page = { | |
| ConfigProvision: Symbol('config'), | ||
| }; | ||
|
|
||
| const formatDialogTitle = (current) => { | ||
| return { | ||
| title: current ? formatMessage('Edit publishing profile') : formatMessage('Create a publishing profile'), | ||
| subText: formatMessage( | ||
| 'To test, run and publish your bot, it needs Azure resources such as app registration, hosting and channels.' + | ||
| ' Other resources, such as language understanding and storage are optional.' + | ||
| ' A publishing profile contains all of the information necessary to provision and publish your bot, including its Azure resources.' | ||
| ), | ||
| }; | ||
| }; | ||
|
|
||
| export const PublishProfileDialog: React.FC<PublishProfileDialogProps> = (props) => { | ||
| const { | ||
| current, | ||
|
|
@@ -54,14 +65,10 @@ export const PublishProfileDialog: React.FC<PublishProfileDialogProps> = (props) | |
| const [page, setPage] = useState(Page.ProfileForm); | ||
| const [publishSurfaceStyles, setStyles] = useState(defaultPublishSurface); | ||
| const { provisionToTarget, addNotification } = useRecoilValue(dispatcherState); | ||
|
|
||
| const [dialogTitle, setTitle] = useState({ | ||
| title: current ? formatMessage('Edit publishing profile') : formatMessage('Add new publishing profile'), | ||
| subText: formatMessage('A publishing profile provides the secure connectivity required to publish your bot. '), | ||
| }); | ||
|
|
||
| const [selectedType, setSelectType] = useState<PublishType | undefined>(); | ||
|
|
||
| const [dialogTitle, setTitle] = useState(formatDialogTitle(current)); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. after making the type of formatDialogTitle boolean, change this to
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will need to pick this up in a future PR. |
||
|
|
||
| useEffect(() => { | ||
| const ty = types.find((t) => t.name === current?.item.type); | ||
| setSelectType(ty); | ||
|
|
@@ -89,10 +96,7 @@ export const PublishProfileDialog: React.FC<PublishProfileDialogProps> = (props) | |
| PluginAPI.publish.closeDialog = closeDialog; | ||
| PluginAPI.publish.onBack = () => { | ||
| setPage(Page.ProfileForm); | ||
| setTitle({ | ||
| title: current ? formatMessage('Edit publishing profile') : formatMessage('Add new publishing profile'), | ||
| subText: formatMessage('A publishing profile provides the secure connectivity required to publish your bot. '), | ||
| }); | ||
| setTitle(formatDialogTitle(current)); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same comment L70
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will need to pick this up in a future PR. |
||
| }; | ||
| PluginAPI.publish.getTokenFromCache = () => { | ||
| return { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change
currenthere toisEditing: booleanThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need to pick this up in a future PR.