Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: split "Add new" button into its own section on Publish Targets page #7512

Merged
beyackle merged 7 commits into from
May 3, 2021
Merged

fix: split "Add new" button into its own section on Publish Targets page #7512

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4e0c9f8
Update PublishTargets.tsx
beyackle Apr 29, 2021
8d1170f
Merge branch 'main' into beyackle/7491_publishPageWidths
beyackle Apr 29, 2021
c4799bd
Merge branch 'main' into beyackle/7491_publishPageWidths
beyackle Apr 30, 2021
0268781
Merge branch 'main' into beyackle/7491_publishPageWidths
beyackle Apr 30, 2021
cd97eb5
streamline some logic and rename variables for clarity
beyackle Apr 30, 2021
08e91c0
Merge branch 'main' into beyackle/7491_publishPageWidths
beyackle Apr 30, 2021
ab9b0e3
Merge branch 'main' into beyackle/7491_publishPageWidths
beyackle May 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 21 additions & 13 deletions Composer/packages/client/src/pages/botProject/PublishTargets.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ const publishTargetsContainer = css`
flex-direction: column;
`;

const belowTargetsContainer = css`
padding: 0 20px 20px 20px;
`;

const publishTargetsHeader = css`
display: flex;
flex-direction: row;
Expand Down Expand Up @@ -103,6 +107,22 @@ export const PublishTargets: React.FC<PublishTargetsProps> = (props) => {
}
};

const addNewButton = (
Comment thread
beyackle marked this conversation as resolved.
<ActionButton
data-testid={'addNewPublishProfile'}
styles={actionButton}
onClick={() => {
if (isShowAuthDialog(true)) {
Comment thread
beyackle marked this conversation as resolved.
Outdated
setShowAuthDialog(true);
} else {
setDialogHidden(false);
}
}}
>
{formatMessage('Add new')}
</ActionButton>
);

return (
<Fragment>
<div ref={publishTargetsRef} css={publishTargetsContainer} id="addNewPublishProfile">
Expand Down Expand Up @@ -148,20 +168,8 @@ export const PublishTargets: React.FC<PublishTargetsProps> = (props) => {
</div>
);
})}
<ActionButton
data-testid={'addNewPublishProfile'}
styles={actionButton}
onClick={() => {
if (isShowAuthDialog(true)) {
setShowAuthDialog(true);
} else {
setDialogHidden(false);
}
}}
>
{formatMessage('Add new')}
</ActionButton>
</div>
<div css={belowTargetsContainer}>{addNewButton}</div>
{showAuthDialog && (
<AuthDialog
needGraph
Expand Down