Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@ import { renderHook } from '@botframework-composer/test-utils/lib/hooks';
import { useRecognizerConfig } from '../useRecognizerConfig';
import { EditorExtensionContext } from '../../EditorExtensionContext';

const shellData = { currentDialog: { content: {} } };
const shellData = {
currentDialog: { content: {} },
schemas: { sdk: { content: { definitions: { foo: 'foo schema', bar: 'bar schema' } } } },
};
const plugins = {
uiSchema: {
foo: {
Expand All @@ -20,6 +23,11 @@ const plugins = {
menu: {},
recognizer: { displayName: 'recognizer 2' },
},
notInAppSchema: {
form: {},
menu: {},
recognizer: { displayName: 'not in app schema' },
},
},
};

Expand All @@ -43,4 +51,9 @@ describe('useRecognizerConfig', () => {
},
]);
});

it("omits recognizer config that isn't in the schema", () => {
const { result } = renderHook(() => useRecognizerConfig(), { wrapper });
expect(Object.keys(result.current.recognizers)).not.toContain('notInAppSchema');
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,16 @@ export interface RecognizerSchemaConfig {

export function useRecognizerConfig(): RecognizerSchemaConfig {
const { plugins, shellData } = useContext(EditorExtensionContext);
const appSchema = shellData.schemas?.sdk?.content;

const recognizers: RecognizerSchema[] = useMemo(() => {
if (!plugins.uiSchema) return [];

const recognizerWidgets = plugins.widgets?.recognizer ?? {};
const schemas = Object.entries(plugins.uiSchema)
.filter(([_, uiOptions]) => uiOptions?.recognizer)
.filter(([$kind, uiOptions]) => {
return Boolean(uiOptions?.recognizer && appSchema?.definitions?.[$kind]);
})
.map(([$kind, uiOptions]) => {
const recognizerOptions = uiOptions?.recognizer as RecognizerOptions;
const intentEditor = resolveRecognizerWidget(recognizerOptions.intentEditor, recognizerWidgets);
Expand Down