Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: luis provisioning to return location #7431

Merged
cwhitten merged 2 commits into from
Apr 27, 2021
Merged

fix: luis provisioning to return location #7431

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f984ad
Fixed luis provisioning to return location
GeoffCoxMSFT Apr 27, 2021
d0e1e0e
Merge branch 'main' into gcox/mainwork1
cwhitten Apr 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions extensions/azurePublish/src/node/azureResourceManager/azureResourceManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,9 @@ export class AzureResourceMananger {
* Deploy luis authoring resource
* @param config
*/
public async deployLuisAuthoringResource(config: LuisAuthoringResourceConfig) {
public async deployLuisAuthoringResource(
config: LuisAuthoringResourceConfig
): Promise<{ authoringKey: string; authoringEndpoint: string; location: string }> {
try {
this.logger({
status: BotProjectDeployLoggerType.PROVISION_INFO,
Expand Down Expand Up @@ -170,7 +172,8 @@ export class AzureResourceMananger {
const authoringEndpoint = deployResult.properties?.endpoint ?? '';
const keys = await cognitiveServicesManagementClient.accounts.listKeys(config.resourceGroupName, config.name);
const authoringKey = keys?.key1 ?? '';
return { authoringKey, authoringEndpoint };
const location = deployResult.location;
return { authoringKey, authoringEndpoint, location };
} catch (err) {
this.logger({
status: BotProjectDeployLoggerType.PROVISION_ERROR,
Expand All @@ -184,7 +187,9 @@ export class AzureResourceMananger {
* Deploy luis resource
* @param config
*/
public async deployLuisResource(config: LuisResourceConfig): Promise<{ endpoint: string; endpointKey: string }> {
public async deployLuisResource(
config: LuisResourceConfig
): Promise<{ endpoint: string; endpointKey: string; location: string }> {
try {
this.logger({
status: BotProjectDeployLoggerType.PROVISION_INFO,
Expand Down Expand Up @@ -218,7 +223,8 @@ export class AzureResourceMananger {
const endpoint = deployResult.properties?.endpoint ?? '';
const keys = await cognitiveServicesManagementClient.accounts.listKeys(config.resourceGroupName, config.name);
const endpointKey = keys?.key1 ?? '';
return { endpoint, endpointKey };
const location = deployResult.location;
return { endpoint, endpointKey, location };
} catch (err) {
this.logger({
status: BotProjectDeployLoggerType.PROVISION_ERROR,
Expand Down