-
Notifications
You must be signed in to change notification settings - Fork 374
Conversation
|
I have done some thinking about this as well, here is the doc. Our thinking is closely aligned - one script for creating resources, another for doing repeated deploys. I would like to minimize the number of parameters required from a user -- I believe we can do this with just a bot name and a 16-character password. The resource names can be generated based on the bot name. Refer to the details in this ticket: |
|
@benbrown @yochay @zidaneymar We knew this going in, but got additional feedback from SDK & Tools group that the Powershell script here will cause friction that we'll need to address eventually. We should consider porting this script to run from a node runtime early. Is there a specific reason this is out of scope? |
|
The main reason for keeping this out of scope is to leverage exiting, already working solutions, in the form of the VA scripts. I talked to Lauren and we agree we can update both project based on Composer needs. Another reasons, is the lack of JS runtime will cause even a larger friction, specially since this design calls for choosing your runtime during new bot creation. With that said, PowerShell 6 runs on Mac and is currently the only ship vehicle for Virtual Assistant. I agree that when Composer GA and fully support both JS and C# bot runtime, we need to provide a more generic CLI experience. Could be in the form of node, or native Az CLI, which is Python |
|
|
||
| $settings | Add-Member -Type NoteProperty -Force -Name 'microsoftAppId' -Value $appId | ||
| $settings | Add-Member -Type NoteProperty -Force -Name 'microsoftAppPassword' -Value $appPassword | ||
| $settings | Add-Member -Type NoteProperty -Force -Name 'bot' -Value "RunningInstance" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RunningInstance [](start = 70, length = 15)
wenyi is working on editing environment variables in composer and post them to bot project, how could those settings passed to this deployment script??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now the script search the appsettings.json file in bot and merge with the main appsettings.json in BotProject root folder.
|
@zidaneymar , this is great. I'll test the scripts shortly. Let's keep this item and #699 open until we complete the work around for provisioning LUIS keys, having Adaptive work with Cosmos and add support for storage middleware (for transcript logging). |
|
After running the create script, my Is this intentional? I think it makes sense to write these values to the file. |
|
DEPLOY:
CREATE:
|
Fixed in #833 |
08/28 Update:
Refer to #699
create.ps1
deploy.ps1
Usage:
.\Scripts\create.ps1 -name TestBotProject0828 -location westus -appPassword qikangqikang123$ -environment testenv
.\Scripts\deploy.ps1 -name TestBotProject0828 -environment testenv -botPath ....\SampleBots\ToDoBot
For now it doesn't include luis publishing.
Deprecated:
Deployment Process
Deploy Azure Resource
Publish bot runtime (.dll ) and dialog files (including .lu and .lg)
Publish process (update bot file “publish.ps1” script)
Publish bot runtime (.dll ) and dialog files (including .lu and .lg)
for luis settting, need more discussions.
Task Item
#699
Type of change
Please delete options that are not relevant.
Checklist
Screenshots
Please include screenshots or gifs if your PR include UX changes.