Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: disable telemetry calls in the provision dialog while we investigate … #7256

Merged
benbrown merged 2 commits into from
Apr 22, 2021
Merged

fix: disable telemetry calls in the provision dialog while we investigate … #7256

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cb4217
disable telemetry calls in the provision dialog while we investigate …
benbrown Apr 22, 2021
26ae838
Merge branch 'main' into benbrown/rollbacktelem
GeoffCoxMSFT Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions extensions/azurePublish/src/components/azureProvisionDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,8 @@ export const AzureProvisionDialog: React.FC = () => {
} = usePublishApi();
const telemetryClient: TelemetryClient = useTelemetryClient();

console.log('TELEMETRY CLIENT', telemetryClient);
Copy link
Member

@GeoffCoxMSFT GeoffCoxMSFT Apr 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want the console.log left in here?


const { setItem, getItem, clearAll } = useLocalStorage();
// set type of publish - azurePublish or azureFunctionsPublish
const publishType = getType();
Expand Down Expand Up @@ -362,22 +364,22 @@ export const AzureProvisionDialog: React.FC = () => {
setPage(page);
switch (page) {
case PageTypes.AddResources:
telemetryClient.track('ProvisionAddResourcesNavigate');
// telemetryClient.track('ProvisionAddResourcesNavigate');
setTitle(DialogTitle.ADD_RESOURCES);
break;
case PageTypes.ChooseAction:
setTitle(DialogTitle.CHOOSE_ACTION);
break;
case PageTypes.ConfigProvision:
telemetryClient.track('ProvisionConfigureResources');
// telemetryClient.track('ProvisionConfigureResources');
setTitle(DialogTitle.CONFIG_RESOURCES);
break;
case PageTypes.EditJson:
telemetryClient.track('ProvisionEditJSON');
// telemetryClient.track('ProvisionEditJSON');
setTitle(DialogTitle.EDIT);
break;
case PageTypes.ReviewResource:
telemetryClient.track('ProvisionReviewResources');
// telemetryClient.track('ProvisionReviewResources');
setTitle(DialogTitle.REVIEW);
break;
}
Expand Down Expand Up @@ -704,11 +706,11 @@ export const AzureProvisionDialog: React.FC = () => {
const onSubmit = useCallback((options) => {
// call back to the main Composer API to begin this process...

telemetryClient.track('ProvisionStart', {
region: options.location,
subscriptionId: options.subscription,
externalResources: options.externalResources,
});
// telemetryClient.track('ProvisionStart', {
// region: options.location,
// subscriptionId: options.subscription,
// externalResources: options.externalResources,
// });

startProvision(options);
clearAll();
Expand Down Expand Up @@ -981,7 +983,7 @@ export const AzureProvisionDialog: React.FC = () => {
style={{ margin: '0 4px' }}
text={formatMessage('Cancel')}
onClick={() => {
telemetryClient.track('ProvisionCancel');
// telemetryClient.track('ProvisionCancel');
closeDialog();
}}
/>
Expand Down Expand Up @@ -1077,7 +1079,7 @@ export const AzureProvisionDialog: React.FC = () => {
text={formatMessage('Next')}
onClick={() => {
if (formData.creationType === 'generate') {
telemetryClient.track('ProvisionShowHandoff');
// telemetryClient.track('ProvisionShowHandoff');
setShowHandoff(true);
} else {
setPageAndTitle(PageTypes.ReviewResource);
Expand All @@ -1101,7 +1103,7 @@ export const AzureProvisionDialog: React.FC = () => {
style={{ margin: '0 4px' }}
text={formatMessage('Cancel')}
onClick={() => {
telemetryClient.track('ProvisionAddResourcesCancel');
// telemetryClient.track('ProvisionAddResourcesCancel');
closeDialog();
}}
/>
Expand Down