fix: Remove tag entity menu from LU Toolbar

Composer/packages/lib/code-editor/src/lu/InsertEntityButton.tsx

@@ -53,26 +53,18 @@ export const InsertEntityButton = React.memo((props: Props) => {
     [onInsertEntity]
   );
 
-  const { menuProps, noEntities } = useLabelingMenuProps(labelingMenuVisible ? 'disable' : 'none', luFile, itemClick, {
-    menuHeaderText: labelingMenuVisible ? formatMessage('Tag entity') : undefined,
-  });
+  const { menuProps, noEntities } = useLabelingMenuProps(labelingMenuVisible ? 'disable' : 'none', luFile, itemClick);
 
-  const mode = React.useMemo(() => (labelingMenuVisible ? 'tag' : 'insert'), [labelingMenuVisible]);
-  const disabled = React.useMemo(
-    () => noEntities || (mode === 'tag' && tagEntityDisabled) || (mode === 'insert' && insertEntityDisabled),
-    [mode, noEntities, insertEntityDisabled, tagEntityDisabled]
-  );
+  const disabled = React.useMemo(() => noEntities || insertEntityDisabled || labelingMenuVisible, [
+    noEntities,
+    insertEntityDisabled,
+    tagEntityDisabled,
+    labelingMenuVisible,
+  ]);
 
-  const { iconName, text } = React.useMemo(
-    () => getLuToolbarItemTextAndIcon(labelingMenuVisible ? 'tagEntity' : 'useEntity'),
-    [labelingMenuVisible]
-  );
+  const { iconName, text } = React.useMemo(() => getLuToolbarItemTextAndIcon('useEntity'), []);
 
-  const CommandBarButton = React.useMemo(
-    () =>
-      getCommandBarButton(labelingMenuVisible ? formatMessage('Tag entity') : formatMessage('Insert defined entity')),
-    [labelingMenuVisible]
-  );
+  const CommandBarButton = React.useMemo(() => getCommandBarButton(formatMessage('Insert defined entity')), []);
 
   return (
     <CommandBarButton

Composer/packages/lib/code-editor/src/lu/LuLabelingMenu.tsx

@@ -87,7 +87,7 @@ export const LuLabelingMenu = ({ editor, luFile, onMenuToggled, onInsertEntity }
   );
 
   const { menuProps, noEntities } = useLabelingMenuProps('filter', luFile, itemClick, {
-    menuHeaderText: formatMessage('Tag entity'),
+    menuHeaderText: formatMessage('Label entity'),
   });
 
   return menuTargetElm && !noEntities ? (

Composer/packages/lib/code-editor/src/lu/__test__/InsertEntityButton.test.tsx

@@ -88,29 +88,4 @@ describe('<InsertEntityButton />', () => {
 
     expect((await screen.findAllByText(/.*target.*/)).length).toBe(1);
   });
-
-  it('Should disable non-ml entities when labeling menu is visible', async () => {
-    const container = render(
-      <InsertEntityButton
-        insertEntityDisabled
-        labelingMenuVisible
-        luFile={luFile}
-        tagEntityDisabled={false}
-        onInsertEntity={jest.fn()}
-      />
-    );
-
-    fireEvent.click(screen.getByTestId('menuButton'));
-    const elms = container.getAllByText('Prebuilt entity');
-
-    const allDisabled = elms.reduce((acc, elm) => {
-      if (!elm.closest('button')?.classList.contains('is-disabled')) {
-        acc = false;
-      }
-
-      return acc;
-    }, true);
-
-    expect(allDisabled).toBeTruthy();
-  });
 });

Composer/packages/lib/code-editor/src/lu/iconUtils.tsx

@@ -13,9 +13,5 @@ export const getLuToolbarItemTextAndIcon = (kind: LuToolbarButtonKind): { iconNa
     case 'useEntity': {
       return { iconName: 'Insert', text: formatMessage('Insert entity') };
     }
-
-    case 'tagEntity': {
-      return { iconName: 'Highlight', text: formatMessage('Tag entity') };
-    }
   }
 };

Composer/packages/lib/code-editor/src/lu/types.ts

@@ -3,4 +3,4 @@
 
 export const toolbarSupportedLuEntityTypes = ['prebuilt', 'ml', 'list', 'composite', 'regex'] as const;
 export type ToolbarLuEntityType = typeof toolbarSupportedLuEntityTypes[number];
-export type LuToolbarButtonKind = 'useEntity' | 'defineEntity' | 'tagEntity';
+export type LuToolbarButtonKind = 'useEntity' | 'defineEntity';