fix: Add msAppId and subscriptionId to PublishingProfileCompleted telemetry

Composer/packages/server/src/controllers/publisher.ts

@@ -73,15 +73,20 @@ export const PublishController = {
         msAppId: configuration.settings?.MicrosoftAppId,
         subscriptionId: configuration.subscriptionId,
       });
+
+      TelemetryService.startEvent('PublishingProfileCompleted', `${target}${projectId}`, {
+        target,
+        projectId,
+        msAppId: configuration.settings?.MicrosoftAppId,
+        subscriptionId: configuration.subscriptionId,
+      });
     } catch (error) {
       TelemetryService.trackEvent('PublishingProfileStarted', {
         target,
         projectId,
       });
     }
 
-    TelemetryService.startEvent('PublishingProfileCompleted', `${target}${projectId}`, { target, projectId });
-
     log('access token retrieved from body: %s', accessToken || 'no token provided');
     if (profile && extensionImplementsMethod(extensionName, 'publish')) {
       // append config from client(like sensitive settings)

Composer/packages/types/src/telemetry.ts

@@ -111,7 +111,7 @@ type PublishingEvents = {
   NewPublishingProfileStarted: undefined;
   NewPublishingProfileSaved: { type: string; msAppId?: string; subscriptionId?: string };
   PublishingProfileStarted: { target: string; projectId: string; msAppId?: string; subscriptionId?: string };
-  PublishingProfileCompleted: { target: string; projectId: string };
+  PublishingProfileCompleted: { target: string; projectId: string; msAppId?: string; subscriptionId?: string };
 };
 
 type AppSettingsEvents = {