This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: Move auth to when provisioning needs it. #6927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoffCoxMSFT
requested review from
benbrown,
hatpick and
tonyanziano
as code owners
benbrown
approved these changes
Apr 14, 2021
Contributor
benbrown
left a comment
benbrown
left a comment
There was a problem hiding this comment.
I would recommend that we disable the fields on the form when we are doing auth and loading in the supporting values via API calls...
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* fix: 6566 Update provision handoff copy * fix: 6851 * Moved sign-in to config page
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Turns out that calling getTenants will pop the sign-in dialog when in electron.
I moved the getTenants call to only run when the page that has the dropdown of them loads.
I updated the error message to semantically be about the tenants and improved the error message strings.
Task Item
fixes #6562
fixes #6900
fixes: #6776
Screenshots
N/A (offline video available)