Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@hatpick
Copy link
Contributor

@hatpick hatpick commented Apr 13, 2021

Description

Fixes the followings:

  1. deleting a dialog when it's selected in the tree crashes the app
  2. react unique key warnings
  3. react mutate state on an unmounted component

Task Item

closes #6812

@hatpick hatpick changed the title Fix: deleting a dialog when it's selected in the tree crashes the app fix: deleting a dialog when it's selected in the tree crashes the app Apr 13, 2021
@a-b-r-o-w-n a-b-r-o-w-n merged commit 5a1d204 into main Apr 13, 2021
@a-b-r-o-w-n a-b-r-o-w-n deleted the sorgh/6812 branch April 13, 2021 18:15
@coveralls
Copy link

coveralls commented Apr 13, 2021

Coverage Status

Coverage increased (+0.001%) to 51.143% when pulling b8ed72a on sorgh/6812 into 58c8ad9 on main.

@cwhitten cwhitten mentioned this pull request May 20, 2021
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
…microsoft#6904)

* react key issues

* fix effect warning

* fix app crash

Co-authored-by: Soroush <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

delete dialog with empty sendactivity will break composer

5 participants