Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: bot can't start or publish by cleaning unused code #6816

Merged
boydc2014 merged 6 commits into from
Apr 9, 2021
Merged

fix: bot can't start or publish by cleaning unused code #6816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2cf3c16
Guard setSkillManifest
boydc2014 Apr 9, 2021
4334e12
Merge branch 'main' into donglei/guard-skill-manifest
boydc2014 Apr 9, 2021
773ca04
remove unused code
boydc2014 Apr 9, 2021
bc3ce24
Merge branch 'donglei/guard-skill-manifest' of https://github.com/mic…
boydc2014 Apr 9, 2021
a7af848
Still keep it under guard
boydc2014 Apr 9, 2021
67e30c7
remove
boydc2014 Apr 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions extensions/azurePublish/src/node/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,6 @@ export default async (composer: IExtensionRegistration): Promise<void> => {
) => {
const { subscriptionID, accessToken, name, environment, hostname, luisResource, abs } = customizeConfiguration;

const mode = this.getRuntimeTemplateMode(runtime?.key);

// Create the BotProjectDeploy object, which is used to carry out the deploy action.
const azDeployer = new BotProjectDeploy({
logger: (msg: any, ...args: any[]) => {
Expand Down
14 changes: 0 additions & 14 deletions extensions/localPublish/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,23 +120,9 @@ class LocalPublisher implements PublishPlugin<PublishConfig> {

await this.initBot(project);
await this.saveContent(botId, version, project.dataDir, user);
await runtime.setSkillManifest(
this.getBotRuntimeDir(botId),
project.fileStorage,
this.getManifestSrcDir(project.dataDir),
project.fileStorage,
'azurewebapp'
);
} else if (project.settings.runtime.path && project.settings.runtime.command) {
const runtimePath = project.getRuntimePath();
await runtime.build(runtimePath, project);
await runtime.setSkillManifest(
project.settings.runtime.path,
project.fileStorage,
this.getManifestSrcDir(project.dataDir),
project.fileStorage,
'azurewebapp'
);
} else {
throw new Error('Custom runtime settings are incomplete. Please specify path and command.');
}
Expand Down