Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: bot can't start or publish by cleaning unused code #6816

Merged
boydc2014 merged 6 commits into from
Apr 9, 2021
Merged

fix: bot can't start or publish by cleaning unused code #6816

boydc2014 merged 6 commits into from
Apr 9, 2021

Conversation

@boydc2014
Copy link
Contributor

@boydc2014 boydc2014 commented Apr 9, 2021 •
edited
Loading

image
image
#minor

@boydc2014 boydc2014 changed the title fix: check runtime.setSkillManifest before calling fix: clean unused code Apr 9, 2021
@coveralls
Copy link

coveralls commented Apr 9, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 51.141% when pulling 67e30c7 on donglei/guard-skill-manifest into 683520a on main.

@boydc2014
Copy link
Contributor Author

boydc2014 commented Apr 9, 2021

Looks like the setSkillManifest is not used anymore, @benbrown can you help confirm?

@boydc2014 boydc2014 changed the title fix: clean unused code fix: check setSkillManifest and clean unused code Apr 9, 2021
@boydc2014 boydc2014 changed the title fix: check setSkillManifest and clean unused code fix: clean unused code Apr 9, 2021
@boydc2014 boydc2014 changed the title fix: clean unused code fix: bot can't start or publish by cleaning unused code Apr 9, 2021
@boydc2014 boydc2014 merged commit d892234 into main Apr 9, 2021
@boydc2014 boydc2014 deleted the donglei/guard-skill-manifest branch April 9, 2021 06:28
alanlong9278 added a commit that referenced this pull request Apr 9, 2021
@alanlong9278
Merge branch 'main' into qika/skill
77950bc 
* main:
  fix: bot can't start or publish by cleaning unused code (#6816)
alanlong9278 added a commit that referenced this pull request Apr 9, 2021
@alanlong9278
Merge branch 'qika/skill' into julong/skill
bc430c7 
* qika/skill:
  tooltip
  fix: bot can't start or publish by cleaning unused code (#6816)
  fix: make composer support https proxy (#6766)
This was referenced Apr 9, 2021
Closed
Closed
srinaath pushed a commit that referenced this pull request Apr 21, 2021
Revert "fix: bot can't start or publish by cleaning unused code (#6816)"
38719d6 
This reverts commit d892234.

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

# Conflicts:
#	extensions/localPublish/src/index.ts
@cwhitten cwhitten mentioned this pull request May 20, 2021
Merged
benbrown pushed a commit to benbrown/BotFramework-Composer that referenced this pull request May 24, 2021
@alanlong9278
Merge branch 'main' into qika/skill
7f08358 
* main:
  fix: bot can't start or publish by cleaning unused code (microsoft#6816)
benbrown pushed a commit to benbrown/BotFramework-Composer that referenced this pull request May 24, 2021
@alanlong9278
Merge branch 'qika/skill' into julong/skill
258dc0f 
* qika/skill:
  tooltip
  fix: bot can't start or publish by cleaning unused code (microsoft#6816)
  fix: make composer support https proxy (microsoft#6766)
benbrown pushed a commit that referenced this pull request Jun 11, 2021
@alanlong9278
Merge branch 'main' into qika/skill
72e8792 
* main:
  fix: bot can't start or publish by cleaning unused code (#6816)
benbrown pushed a commit that referenced this pull request Jun 11, 2021
@alanlong9278
Merge branch 'qika/skill' into julong/skill
100da3c 
* qika/skill:
  tooltip
  fix: bot can't start or publish by cleaning unused code (#6816)
  fix: make composer support https proxy (#6766)
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@boydc2014
fix: bot can't start or publish by cleaning unused code (microsoft#6816)
8270a78 
* Guard setSkillManifest

* remove unused code

* Still keep it under guard

* remove
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@cwhitten cwhitten Awaiting requested review from cwhitten

@benbrown benbrown Awaiting requested review from benbrown

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@hatpick hatpick Awaiting requested review from hatpick

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

1 more reviewer

@luhan2017 luhan2017 luhan2017 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@luhan2017 luhan2017

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@boydc2014 @coveralls @luhan2017