This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: loading spinner text to be more readable, appSettings toggle overlap bug #6805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolum
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
srinaath
reviewed
Apr 8, 2021
srinaath
reviewed
Apr 8, 2021
srinaath
approved these changes
Apr 8, 2021
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…rlap bug (microsoft#6805) * updating loading spinner to be within modal * Move advanced settings toggle above tabs * Changing padding to pixels, removing border
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small UI changes to resolve two UI bugs.
First bug is that the loading text was hard to read during bot creation so that has been formatted to be rendered in its own modal similar to the spinner one sees when installing a new package
Second bug was the positioning of the toggle for advanced settings which overlapped the json editor and led to character overlap between the toggle and text in the JSON editor.
Task Item
fixes #6663
fixes #6801
Screenshots