This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feat: Added selected state to Web Chat log panel and auto-inspection on load #6782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick and
srinaath
as code owners
srinaath
reviewed
Apr 8, 2021
...r/packages/client/src/pages/design/DebugPanel/TabExtensions/WebChatLog/WebChatLogContent.tsx
Outdated
Show resolved
Hide resolved
srinaath
reviewed
Apr 8, 2021
Composer/packages/client/src/recoilModel/dispatchers/webchat.ts
Outdated
Show resolved
Hide resolved
hatpick
reviewed
Apr 8, 2021
...r/packages/client/src/pages/design/DebugPanel/TabExtensions/WebChatLog/WebChatLogContent.tsx
Outdated
Show resolved
Hide resolved
...r/packages/client/src/pages/design/DebugPanel/TabExtensions/WebChatLog/WebChatLogContent.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/recoilModel/dispatchers/webchat.ts
Outdated
Show resolved
Hide resolved
…/BotFramework-Composer into toanzian/log-selection
srinaath
previously approved these changes
Apr 9, 2021
…/BotFramework-Composer into toanzian/log-selection
…/BotFramework-Composer into toanzian/log-selection
hatpick
approved these changes
Apr 9, 2021
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…on load (microsoft#6782) * Added selected state to web chat log items * Latest item in log now selected if nothing is selected. * Moved log entry sorting to dispatcher * Made `id` property mandatory * Fixed tests * Moved Web Chat log item ID generation to instantiation Co-authored-by: Srinaath Ravichandran <[email protected]> Co-authored-by: Soroush <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a selected state to the currently inspected web chat log item, and it also auto-inspects the latest log item if the panel is active and no item is currently being inspected.
Task Item
Fixes #6749
Screenshots
Selected log item
Later log item is currently being inspected, but hovering an earlier log item