This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: fixed CosmosDb parameter name in Readme #6756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipelteixeira
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
Contributor
Author
|
@cwhitten added new PR change here to avoid merge problems |
filipelteixeira
changed the title
Member
|
Thank you for the contribution! |
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Co-authored-by: Chris Whitten <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createCosmosDB to createCosmosDb
Description
Found a small typo in the project generated readme file, that prevented the Cosmos DB resource to not be created, if used as described. The value is case sensitive, and is written as createCosmosDB instead of createCosmosDb.
I was provisioning the Azure infrastructure for an article I wrote about MBF and found out the Cosmos DB resource was still being created although I used the correct described value set as false.
After looking into the script code, I realized that the value had a typo, and recreated with the correct parameter name. It worked. :)
Task Item
Didn't found an issue related to it. #minor
Screenshots