This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feature: Provisioning partial success handling #6752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoffCoxMSFT
requested review from
a-b-r-o-w-n,
benbrown,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
hatpick
reviewed
Apr 7, 2021
| if ( | ||
| (response.data?.status === 200 || response.data?.status === 206) && | ||
| response.data.config && | ||
| response.data.config != {} |
Contributor
There was a problem hiding this comment.
nit: use lodash isEmpty({})
hatpick
approved these changes
Apr 7, 2021
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Co-authored-by: Soroush <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When provisioning if one resource fails, this returns partial success and puts up a warning notification.
The profile is also saved on partial success.
The user will be able to open the profile target and try provisioning again.
Task Item
closes #5959
Screenshots
Manually introduced error to show this partial success (uses the standard warning card for the notification)
Prod7 profile was saved
