Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

chore: Improve l10n build performance #6737

Merged
GeoffCoxMSFT merged 3 commits into from
Apr 7, 2021
Merged

chore: Improve l10n build performance #6737

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7976a1
Excluding folders from l10n
GeoffCoxMSFT Apr 7, 2021
a0ca3eb
Merge branch 'main' into gcox/l10nperf
GeoffCoxMSFT Apr 7, 2021
477db92
Merge branch 'main' into gcox/l10nperf
GeoffCoxMSFT Apr 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions Composer/babel.l10n.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,34 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

// TODO: It would be nice to use the regular expression matching.
// It would be nice to ignore the lib folders rather than listing them one at a time.
// However, as of 4/2021 it doesn't seem to work.
// We have the added complexity that packages/lib contains folders we DO want to process.

@a-b-r-o-w-n a-b-r-o-w-n Apr 7, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Easiest thing to do is probably just remove the lib directory and move the contents up a directory.

@GeoffCoxMSFT GeoffCoxMSFT Apr 7, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. Didn't want to create any major restructure so close to release.

@beyackle beyackle Apr 7, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely agree here, too. It keeps tripping me up that we have regular non-compiled code in a lib folder (and then each package in there has compiled stuff in its own lib folder).

//
// /packages\/(?!lib$).+\/lib(\/.*)*/
// This was the negative lookahead regex I tried, but bable never seemed to honor.
// I verified this regex had the right behavior in a regex tester with many path variations.
module.exports = {
presets: ['@babel/react', ['@babel/typescript', { allowNamespaces: true }]],
plugins: ['@babel/plugin-proposal-class-properties'],
ignore: [
'packages/electron-server',
'packages/**/__tests__',
'packages/**/build',
'packages/**/node_modules',
'packages/**/build/**/*.js',
'packages/adaptive-flow/**/lib',
'packages/adaptive-form/**/lib',
'packages/client/public',
'packages/electron-server',
'packages/extension/**/lib',
'packages/extension-client/**/lib',
'packages/form-dialogs/**/lib',
'packages/intellisense/**/lib',
'packages/lib/**/lib',
'packages/server-workers/**/lib',
'packages/test-utils/**/lib',
'packages/tools/**/lib',
'packages/types/**/lib',
'packages/ui-plugins/**/lib',
],
};