Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: remove log details for creating application registration #6732

Merged
luhan2017 merged 4 commits into from
Apr 7, 2021
Merged

fix: remove log details for creating application registration #6732

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3452cb6
add retry logic for adding app password
Apr 6, 2021
bb9948c
remove detailed error message
Apr 7, 2021
67c17d1
Merge remote-tracking branch 'origin' into qika/addretry
Apr 7, 2021
7132ea9
Merge branch 'main' into qika/addretry
luhan2017 Apr 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions extensions/azurePublish/src/node/provision.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,13 @@ export class BotProjectProvision {
} catch (err) {
this.logger({
status: BotProjectDeployLoggerType.PROVISION_ERROR,
message: `App create failed: ${JSON.stringify(err, null, 4)}, retrying ...`,
message: `App create failed, retrying ...`,
});
if (retryCount == 0) {
throw createCustomizeError(ProvisionErrors.CREATE_APP_REGISTRATION, 'App create failed!');
throw createCustomizeError(
ProvisionErrors.CREATE_APP_REGISTRATION,
'App create failed! Please file an issue on Github.'
);
} else {
await this.sleep(3000);
retryCount--;
Expand Down Expand Up @@ -150,10 +153,13 @@ export class BotProjectProvision {
} catch (err) {
this.logger({
status: BotProjectDeployLoggerType.PROVISION_ERROR,
message: `Add application password failed: ${JSON.stringify(err, null, 4)}, retrying ...`,
message: `Add application password failed, retrying ...`,
});
if (retryCount == 0) {
throw createCustomizeError(ProvisionErrors.CREATE_APP_REGISTRATION, 'Add application password failed!');
throw createCustomizeError(
ProvisionErrors.CREATE_APP_REGISTRATION,
'Add application password failed! Please file an issue on Github.'
);
} else {
await this.sleep(3000);
retryCount--;
Expand Down