This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feature: add new copy UI for provision #6728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoffCoxMSFT
requested review from
benbrown,
hatpick and
tonyanziano
as code owners
benbrown
suggested changes
Apr 6, 2021
extensions/azurePublish/src/components/ChooseProvisionAction.tsx
Outdated
Show resolved
Hide resolved
extensions/azurePublish/src/components/ChooseProvisionAction.tsx
Outdated
Show resolved
Hide resolved
extensions/azurePublish/src/components/ChooseProvisionAction.tsx
Outdated
Show resolved
Hide resolved
extensions/azurePublish/src/components/ChooseProvisionAction.tsx
Outdated
Show resolved
Hide resolved
hatpick
reviewed
Apr 6, 2021
| <TextField | ||
| required | ||
| ariaLabel={formatMessage( | ||
| 'This name will be assigned to all your new resources. For eg-test-web app, test-luis-prediction' |
Contributor
There was a problem hiding this comment.
What does this mean? (I know it's not your change)
Member
Author
There was a problem hiding this comment.
The provisioning code adds some prefixes to resource names that are cascading off this one.
Contributor
There was a problem hiding this comment.
the "english" of it makes no sense is what I meant
extensions/azurePublish/src/components/azureProvisionDialog.tsx
Outdated
Show resolved
Hide resolved
extensions/azurePublish/src/components/azureProvisionDialog.tsx
Outdated
Show resolved
Hide resolved
| onClick={() => { | ||
| clearAll(); | ||
| closeDialog(); | ||
| logOut(); |
Contributor
There was a problem hiding this comment.
should it first logout then closeDialog? since closing the dialog will remove this component from react tree (unmount)
Member
Author
There was a problem hiding this comment.
Unsure. The existing code logs out after closeDialog.
GeoffCoxMSFT
changed the title
…ft/BotFramework-Composer into gcox/newInfoForProvision
…ft/BotFramework-Composer into gcox/newInfoForProvision
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Created choose action step * Updates * PR fixes * Updated links
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the choose action step before configuring azure step.
Task Item
closes #6563
closes #6564
closes #6565
Screenshots