This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feature: Using runtimeKey for webapp vs. functions #6678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoffCoxMSFT
requested review from
beyackle,
boydc2014,
cwhitten,
srinaath and
tonyanziano
as code owners
benbrown
reviewed
Apr 5, 2021
| /** | ||
| * Returns true if the runtime key is adaptive; false otherwise. | ||
| * Example adaptive runtime keys: 'adaptive-runtime-dotnet-webapp' or 'adaptive-runtime-node-functions' | ||
| * Example older adaptive runtime keys: 'csharp-azurewebapp-v2' |
Contributor
There was a problem hiding this comment.
FWIW, this was used for a pretty brief period of time during the early stages of the runtimes. Only people running preview bits would have projects with the csharp-azurewebapp-v2 value.
benbrown
previously approved these changes
Apr 5, 2021
Contributor
benbrown
left a comment
benbrown
left a comment
There was a problem hiding this comment.
Before we merge this, we need to update the migration function that rewrites the settings to modify existing publishing profiles to use this new type.
hatpick
approved these changes
Apr 7, 2021
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Co-authored-by: Soroush <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This uses the project's runtime key to determine if the provisioning should require the Azure web app or Azure function resource.
Also includes required workaround for manual tokens in non-electron for the Azure provisioning dialog flow.
Task Item
closes #6527
Screenshots
One a single item now appears for publishing to Azure
