This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feat: Enable disambiguation across the board for Orchestrator #6669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taicchoumsft
changed the title
taicchoumsft
changed the title
taicchoumsft
changed the title
boydc2014
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
boydc2014
approved these changes
Apr 7, 2021
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…t#6669) Co-authored-by: Dong Lei <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable disambiguation support in Orchestrator across the board. This PR doesn't automatically add the OnChooseIntent trigger, the user needs to do this manually.
Also, there's a case of what should happen when say, QnA and Orchestrator are used in the same dialog. If
CrossTrainedRecognizerSetfires a ChooseIntent with Orchestrator's top scoring intent also "ChooseIntent", then the user has to do some work to extract out Orchestrator's actual results.Task Item
fixes #5747
Screenshots