Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@alanlong9278
Copy link
Contributor

@alanlong9278 alanlong9278 commented Apr 2, 2021

Description

Bug 1

  • Display: Create new kb from scratch after created from url, the url Kb last qna pair will show in the new kb qna pair when adding new pair.
    qna-bugfix
  • Reason: the new qna pair index is not match the selected qna group
  • Solution: set the qna pair index as the selected qna group's startIndex

Bug 2

  • Display: Create new qna pair failed after delete empty qna pair.
    qna-bugfix1
  • Reason: the empty qna pair is not deleted but set isCreateQnaSection as false when clicking delete button, so the updateQnaSection is invoked when re-create the qna pair, but the sectionId is none. The action will trigger the error modal.
  • Solution: delete the empty qna pair.

Expected

qna-bugfix-fix

Task Item

closes #6657

Screenshots

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0003%) to 51.4% when pulling 6cd3417 on julong/qna-bugfix into 31d4ca5 on main.

@boydc2014 boydc2014 merged commit f89063a into main Apr 2, 2021
@boydc2014 boydc2014 deleted the julong/qna-bugfix branch April 2, 2021 10:55
@cwhitten cwhitten mentioned this pull request May 20, 2021
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* fix qna section display err

* delete empty qna pair
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QnA Section action error.

4 participants