This repository was archived by the owner on Jul 9, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 374
feature: Allow selection of different Orchestrator model #6654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boydc2014
approved these changes
Apr 6, 2021
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
) * Fix downloader * Pass Orch setting data to builder * don't set path as default * Minor rename to download API * Cleanup download code * Remove the block by sending response first * Save modelpath and use new models in builder (though not path) * Remove path for this PR * Fix worker error handling * Fix handling of orchcontroller errors * Fix linter errors * add a note on JSON.Parse throw * Fix uts * Fix more UTs * Fix more UTs * extract worker change * Strip out downloader changes Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provides the backend to allow the user to change the Orchestrator model from the defaults. A UI will be provided in a future PR.
The user can change the model by adding the followint to
appsettings.json:If this section is blank or unreadable, we simply use the Orchestrator defaults. If the model is not in the supported Orchestrator list, we throw an error message.
A future PR will allow the user to specify the model download location as well.
Task Item
closes #6400