Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@taicchoumsft
Copy link
Member

@taicchoumsft taicchoumsft commented Apr 2, 2021

Description

Provides the backend to allow the user to change the Orchestrator model from the defaults. A UI will be provided in a future PR.

The user can change the model by adding the followint to appsettings.json:

"orchestrator": {
    "model": {
      "en_intent": "pretrained.20200924.microsoft.dte.00.03.en.onnx",
      "multilingual_intent": "pretrained.20200924.microsoft.dte.00.03.multilingual.onnx"
    }
  }

If this section is blank or unreadable, we simply use the Orchestrator defaults. If the model is not in the supported Orchestrator list, we throw an error message.

A future PR will allow the user to specify the model download location as well.

Task Item

closes #6400

@coveralls
Copy link

coveralls commented Apr 4, 2021

Coverage Status

Coverage decreased (-0.02%) to 51.672% when pulling 11b00db on tachou/orchSelectModelV2 into 0509422 on main.

@boydc2014 boydc2014 merged commit 782604f into main Apr 6, 2021
@boydc2014 boydc2014 deleted the tachou/orchSelectModelV2 branch April 6, 2021 07:19
@cwhitten cwhitten mentioned this pull request May 20, 2021
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
)

* Fix downloader

* Pass Orch setting data to builder

* don't set path as default

* Minor rename to download API

* Cleanup download code

* Remove the block by sending response first

* Save modelpath and use new models in builder (though not path)

* Remove path for this PR

* Fix worker error handling

* Fix handling of orchcontroller errors

* Fix linter errors

* add a note on JSON.Parse throw

* Fix uts

* Fix more UTs

* Fix more UTs

* extract worker change

* Strip out downloader changes

Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Specify alternate models in advanced appsettings (no UI) to use in Orchestrator

4 participants