This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: update l10n files and fix some typos #6652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beyackle
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
srinaath
previously approved these changes
Apr 5, 2021
tonyanziano
reviewed
Apr 13, 2021
tonyanziano
reviewed
Apr 13, 2021
Composer/packages/client/src/pages/publish/pullFailedDialog.tsx
Outdated
Show resolved
Hide resolved
tonyanziano
reviewed
Apr 13, 2021
| callbackHelpers.set( | ||
| selectedTemplateReadMeState, | ||
| formatMessage('### Error encountered when getting template readMe') | ||
| `### ${formatMessage('Error encountered when getting template readme')}` |
Contributor
There was a problem hiding this comment.
should this be README ?
tonyanziano
reviewed
Apr 13, 2021
| [SDKKinds.IfCondition]: { | ||
| label: () => formatMessage('Branch: If/Else'), | ||
| label: () => formatMessage('Branch: If/else'), | ||
| subtitle: () => formatMessage('If Condition'), |
Contributor
There was a problem hiding this comment.
should this be If condition ?
Contributor
Author
There was a problem hiding this comment.
I also made the rest of the subtitles consistent with the casing style.
tonyanziano
reviewed
Apr 13, 2021
Contributor
tonyanziano
left a comment
tonyanziano
left a comment
There was a problem hiding this comment.
Just some minor comments, but looks good otherwise!
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* fix inconsistent URL capitalization * Update skill.test.tsx * Update en-US.json * add suggestions from proofreading pass * Update en-US.json * fix typo * Update ArrayFieldItem.test.tsx * fix capitalization and re-update l10n file * fixes from PR comments * fix failing test and re-update l10n * fix e2e tests * fix e2e tests * fix LuisDeploy e2e test * relabel teaching-bubble refs * fixes from PR comments Co-authored-by: Srinaath Ravichandran <[email protected]> Co-authored-by: Chris Whitten <[email protected]> Co-authored-by: Tony Anziano <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We'd built up another small l10n "bubble" that needed smoothing out, and while looking into it I noticed some small grammar glitches and that we weren't capitalizing URL consistently.
I've also added the suggestions from the proofreading pass here, since it hadn't closed yet and it's easier to just do all of these text changes as one.
Task Item
#minor