fix: clean the hostedBots/botid folder when deleting a bot

Composer/packages/server/src/server.ts

@@ -34,6 +34,7 @@ import DLServerContext from './directline/store/dlServerState';
 import { mountConversationsRoutes } from './directline/mountConversationRoutes';
 import { mountDirectLineRoutes } from './directline/mountDirectlineRoutes';
 import { mountAttachmentRoutes } from './directline/mountAttachmentRoutes';
+import { cleanHostedBots } from './utility/cleanHostedBots';
 
 // eslint-disable-next-line @typescript-eslint/no-var-requires
 const session = require('express-session');
@@ -42,6 +43,7 @@ export async function start(electronContext?: ElectronContext): Promise<number |
   if (electronContext) {
     setElectronContext(electronContext);
   }
+  cleanHostedBots();
   const clientDirectory = path.resolve(require.resolve('@bfc/client'), '..');
   const app: Express = express();
   app.set('view engine', 'ejs');

Composer/packages/server/src/settings/env.ts

@@ -55,3 +55,5 @@ export const extensionDataDir = process.env.COMPOSER_EXTENSION_DATA_DIR || resol
 export const extensionsBuiltinDir = process.env.COMPOSER_BUILTIN_EXTENSIONS_DIR || resolveFromRoot('../extensions');
 export const extensionsRemoteDir =
   process.env.COMPOSER_REMOTE_EXTENSIONS_DIR || resolveFromRoot('.composer/extensions');
+export const localPublishPath =
+  process.env.LOCAL_PUBLISH_PATH || resolveFromRoot('../extensions/localPublish/hostedBots');

Composer/packages/server/src/utility/cleanHostedBots.ts

@@ -0,0 +1,31 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+import { join } from 'path';
+
+import { pathExists, readJson, readdir, remove } from 'fs-extra';
+
+import { appDataPath, localPublishPath } from './../settings/env';
+
+// this function is used to clean the deleted bots in the extensions's cache
+export const cleanHostedBots = async () => {
+  try {
+    if (!(await pathExists(appDataPath))) return;
+    const envData = await readJson(appDataPath);
+
+    if (!envData.projectLocationMap) return;
+    const projects = envData.projectLocationMap;
+
+    let localHostedBots: string[] = [];
+    if (await pathExists(localPublishPath)) {
+      localHostedBots = await readdir(localPublishPath);
+    }
+
+    localHostedBots.forEach((id) => {
+      if (!projects[id]) {
+        remove(join(localPublishPath, id));
+      }
+    });
+  } catch (error) {
+    //TODO: if we can't remove these hostedBots, do we need to show the error
+  }
+};

extensions/localPublish/src/index.ts

@@ -195,7 +195,7 @@ class LocalPublisher implements PublishPlugin<PublishConfig> {
   };
 
   removeRuntimeData = async (botId: string) => {
-    const targetDir = path.resolve(__dirname, `../hostedBots/${botId}`);
+    const targetDir = path.resolve(this.getBotsDir(), `./${botId}`);
     if (!(await this.dirExist(targetDir))) {
       return { msg: `runtime path ${targetDir} does not exist` };
     }