Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@cosmicshuai
Copy link
Contributor

@cosmicshuai cosmicshuai commented Apr 1, 2021

closes #6658

  1. Navigation to Lu file
    luNaviSingleLangFile
  2. Navigation to an intent
    luNaviSingleLangIntent
  3. Navigation in Form Dialog
    luNaviSingleLangForm

Multi-Language Navigations:
luNaviMultiLangFile
luNaviMultiLangIntent
luNaviMultiLangForm
luNaviInContextMenu

@coveralls
Copy link

coveralls commented Apr 1, 2021

Coverage Status

Coverage decreased (-0.03%) to 51.154% when pulling 3849b01 on shuwan/LuGotoDefinition into 2c20585 on main.

@hibrenda hibrenda added this to the R13 milestone Apr 6, 2021
@hatpick
Copy link
Contributor

hatpick commented Apr 7, 2021

From the gifs you included above, it seems like the user should hold down either cmd key on mac, and ctrl key on windows and then click an import and it would jump to the imported file. Does it also support right click and "go to"? the first interaction is kind of hidden and is more for a pro user vs. regular users, it's not very discoverable.

@cosmicshuai
Copy link
Contributor Author

cosmicshuai commented Apr 8, 2021

From the gifs you included above, it seems like the user should hold down either cmd key on mac, and ctrl key on windows and then click an import and it would jump to the imported file. Does it also support right click and "go to"? the first interaction is kind of hidden and is more for a pro user vs. regular users, it's not very discoverable.

@hatpick
I was also wondering that, the monaco editor right click menu was somehow disabled.
The contextmenu is set to false here:


I thought it is designed. If the right click menu is enabled again. User can select 'Goto Definition', and it should work.

@hatpick
Copy link
Contributor

hatpick commented Apr 8, 2021

From the gifs you included above, it seems like the user should hold down either cmd key on mac, and ctrl key on windows and then click an import and it would jump to the imported file. Does it also support right click and "go to"? the first interaction is kind of hidden and is more for a pro user vs. regular users, it's not very discoverable.

@hatpick
I was also wondering that, the monaco editor right click menu was somehow disabled.
The contextmenu is set to false here:

I thought it is designed. If the right click menu is enabled again. User can select 'Goto Definition', and it should work.

Please enable it again, I remember we disabled it as a part of a prototype for a labeler. Is that right @tdurnford ?

@tdurnford
Copy link
Collaborator

@hatpick @cosmicshuai Yes, we disabled the context menu because we were using cmd + click to show the label; however, that is no longer the case, so enabling it should be fine.

@cosmicshuai
Copy link
Contributor Author

@hatpick @tdurnford
I re-enabled the context menu and updated the PR description. Could you take a look?
BTW, do you have any clue that, the completion in LU editing is no longer available?
I looked into the network during editing. The initialized capability was right. But all completion requests has been canceled.
image

@hatpick
Copy link
Contributor

hatpick commented Apr 9, 2021

@cosmicshuai It has something to do with this PR:
#5853

Can you follow up with the author of that PR?

UPDATE:
fixed here #6835

@hatpick hatpick merged commit e1d63c3 into main Apr 9, 2021
@hatpick hatpick deleted the shuwan/LuGotoDefinition branch April 9, 2021 20:19
@cosmicshuai
Copy link
Contributor Author

@hatpick Thanks for the fix!

@cwhitten cwhitten mentioned this pull request May 20, 2021
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* init

* add import regex rules

* add navigation

* add a check file existence before navigation

* simplify code

* fix lint issue

* re-enable context menu in lu editor

Co-authored-by: Soroush <hatpick@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support LU go to definiton

6 participants