This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: Fix field icon border radius #6618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdurnford
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
hatpick
reviewed
Mar 30, 2021
Composer/packages/adaptive-form/src/components/fields/OneOfField/OneOfField.tsx
Outdated
Show resolved
Hide resolved
beyackle
previously approved these changes
Mar 30, 2021
hatpick
reviewed
Mar 30, 2021
Composer/packages/adaptive-form/src/components/fields/StringField.tsx
Outdated
Show resolved
Hide resolved
hatpick
previously approved these changes
Mar 31, 2021
hatpick
approved these changes
Mar 31, 2021
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* fix: Fix field icon border radius * small fix * requested change * fix tests Co-authored-by: Soroush <hatpick@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, fields and field icons have a border radius of 2px which creates an awkward space between the two. This PR updates the field and field icons' border and border radius to appear more continuous.
Task Item
#minor
Screenshots
Current
Updated