This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: update a lot of screen-reader text #6582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beyackle
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
srinaath
reviewed
Apr 7, 2021
| data-testid="diagnostics-tab-header--collapsed" | ||
| > | ||
| <DefaultButton | ||
| ariaLabel={formatMessage('{ errors } errors, { warnings } warnings', { |
Contributor
There was a problem hiding this comment.
Does it need pluralizing here? 1 error 1 warning?
Contributor
Author
There was a problem hiding this comment.
Good catch. I'll fix that too.
…/BotFramework-Composer into beyackle/2021_SRLabels
srinaath
previously approved these changes
Apr 7, 2021
Contributor
|
Looks good @beyackle ! |
srinaath
approved these changes
Apr 7, 2021
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* label on err/warn button and fix "one bot have been found" * add more ARIA labels for SR fixes * refactor tree icons into treeItem * Update treeItem.tsx * fix typecheck errors * fix unit tests * Update en-US.json * unbreak data testIDs * Update ToolbarButtonMenu.test.tsx * post-merge test fix * l10n on object types * fix label one more place * Update DiagnosticsStatus.tsx * Update treeItem.tsx * Update treeItem.tsx * handle iconless items Co-authored-by: Srinaath Ravichandran <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a broad fix to a lot of screen-reader related issues. The following problems referred to in #6559 have been addressed:
Task Item
refs #6559