This repository was archived by the owner on Jul 9, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix manifest generation to use appId from publish profile
Contributor
Author
|
Couple things to button up:
|
Contributor
|
@pavolum - make the "close" button a DefaultButton. |
Contributor
Author
Resolved |
Contributor
Author
All resolved |
hatpick
reviewed
Apr 1, 2021
Composer/packages/client/src/components/Adapters/TeamsManifestGenerator.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/Adapters/TeamsManifestGenerator.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/Adapters/TeamsManifestGenerator.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/Adapters/TeamsManifestGenerator.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/Adapters/TeamsManifestGenerator.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/Adapters/TeamsManifestGenerator.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/Adapters/TeamsManifestGenerator.tsx
Outdated
Show resolved
Hide resolved
…rosoft/BotFramework-Composer into pavolum/addTeamsManifestTool
hatpick
approved these changes
Apr 2, 2021
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Added Teams manifest type defenition and default value * Added Teams manifest modal * Fix defailt manifest * - Add download manifest icon - Fix manifest generation to use appId from publish profile * Add show manifest link * removing unused ref * Fix guid generation * Fixing icon styling * Making requested PR changes * Fixing front end error handling * fixing potentiall undefined param passing * Adding aka.ms link for teams app studio deep link Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: Soroush <hatpick@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When you enable the teams adapter successfully a modal now pops up providing you with the manifest needed to test your bot in Teams.
The modal allows users to copy the manifest to their clipboard, download the manifest and includes a deep link to Teams App studio so users can quickly get to the env in which they are asked to uplaod their manifest and test in teams.
Task Item
fixes #6192
Screenshots