Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@pavolum
Copy link
Contributor

@pavolum pavolum commented Mar 26, 2021

Description

When you enable the teams adapter successfully a modal now pops up providing you with the manifest needed to test your bot in Teams.

The modal allows users to copy the manifest to their clipboard, download the manifest and includes a deep link to Teams App studio so users can quickly get to the env in which they are asked to uplaod their manifest and test in teams.

Task Item

fixes #6192

Screenshots

image

@pavolum
Copy link
Contributor Author

pavolum commented Mar 26, 2021

Couple things to button up:

  • Need to remove hover background affect on icons
  • Need to add a link when adapter is enabled that pulls up manifest tool so users can revisit manifest without needing to trigger modal open via turning Teams off and then back on

@benbrown
Copy link
Contributor

@pavolum - make the "close" button a DefaultButton.

@pavolum
Copy link
Contributor Author

pavolum commented Apr 1, 2021

@pavolum - make the "close" button a DefaultButton.

Resolved

@coveralls
Copy link

coveralls commented Apr 1, 2021

Coverage Status

Coverage decreased (-0.07%) to 51.326% when pulling cf2972b on pavolum/addTeamsManifestTool into 8b7ea1a on main.

@pavolum
Copy link
Contributor Author

pavolum commented Apr 1, 2021

Couple things to button up:

  • Need to remove hover background affect on icons
  • Need to add a link when adapter is enabled that pulls up manifest tool so users can revisit manifest without needing to trigger modal open via turning Teams off and then back on

All resolved

@pavolum pavolum merged commit ef424c5 into main Apr 2, 2021
@pavolum pavolum deleted the pavolum/addTeamsManifestTool branch April 2, 2021 21:39
@cwhitten cwhitten mentioned this pull request May 20, 2021
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* Added Teams manifest type defenition and default value

* Added Teams manifest modal

* Fix defailt manifest

* - Add download manifest icon
- Fix manifest generation to use appId from publish profile

* Add show manifest link

* removing unused ref

* Fix guid generation

* Fixing icon styling

* Making requested PR changes

* Fixing front end error handling

* fixing potentiall undefined param passing

* Adding aka.ms link for teams app studio deep link

Co-authored-by: Patrick Volum <pavolum@microsoft.com>
Co-authored-by: Soroush <hatpick@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Instructions for adding a bot to Teams does not work (Need Manifest)

6 participants