This repository was archived by the owner on Jul 9, 2025. It is now read-only.
chore: Package manager: Update tags for default search terms to msbot-component #6579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosscastro
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
…ithub.com/microsoft/BotFramework-Composer into ccastro/update-component-tag-nomenclature
beyackle
previously approved these changes
Mar 30, 2021
…ithub.com/microsoft/BotFramework-Composer into ccastro/update-component-tag-nomenclature
benbrown
previously approved these changes
Mar 30, 2021
cwhitten
reviewed
Mar 31, 2021
cwhitten
reviewed
Mar 31, 2021
…ithub.com/microsoft/BotFramework-Composer into ccastro/update-component-tag-nomenclature
cwhitten
reviewed
Mar 31, 2021
…ithub.com/microsoft/BotFramework-Composer into ccastro/update-component-tag-nomenclature
Member
Author
|
Linter seems to be happy now. Had some issues running it locally, fixed now. |
Member
|
new lint error:
incidentally, you can run this static analysis locally with |
Member
Author
|
@cwhitten yes I've been running that. I just found the problem. I was running the linter but it was not honoring the rules in the project because of environment stuff in my computer. Sorry for the extra churn! |
…ithub.com/microsoft/BotFramework-Composer into ccastro/update-component-tag-nomenclature
Member
Author
|
Checks were failing due to package source outages, re-running |
cwhitten
approved these changes
Apr 1, 2021
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…-component (microsoft#6579) * Package manager: Update tags for default search terms to msbot-component * Package manager: community packages source read only * Package manager: enforce read-only sources to be read only * Package manager: const variable * Package manager: Add constant for default tag, fix const-correctness of variables * Pacakge manager: localize package source text and remove redundant string type * Package manager: Organize imports * Package manager: fix linter errors Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor