Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@hatpick
Copy link
Contributor

@hatpick hatpick commented Mar 25, 2021

Description

  • Adds insert/tag menu to create trigger modal when default recognizer is luis
  • Updates tooltip and help link for trigger phrases label when default recognizer is luis
  • Prevents floating labeling menu where there are no Luis ML entities

Task Item

#minor

@hatpick
Copy link
Contributor Author

hatpick commented Mar 25, 2021

@tdurnford

@hatpick hatpick added this to the R13 milestone Mar 25, 2021
@hatpick hatpick added Area: LU Belongs to LU feature area LU Editor labels Mar 25, 2021
@coveralls
Copy link

coveralls commented Mar 25, 2021

Coverage Status

Coverage increased (+4.0e-05%) to 52.309% when pulling c88cb26 on sorgh/lu_fixes into 0ac0af8 on main.

"message": "Apr 9, 2020"
},
"are_you_sure_you_want_to_delete_your_bot_this_acti_214a9e11": {
"message": "Are you sure you want to delete your bot? This action cannot be undone and your bot and all related files in the bot project folder will be permanently deleted. Your Azure resources will remain unchanged."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nit: I would have 4 sentences here:
Are you sure you want to delete your bot? This action cannot be undone. Your bot and all related files in the bot project folder will be permanently deleted. Your Azure resources will remain unchanged.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GeoffCoxMSFT Out of curiosity, why would you opt for separate sentences?

@GeoffCoxMSFT GeoffCoxMSFT merged commit 08bb6f5 into main Mar 26, 2021
@GeoffCoxMSFT GeoffCoxMSFT deleted the sorgh/lu_fixes branch March 26, 2021 00:05
@cwhitten cwhitten mentioned this pull request May 20, 2021
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* enable insert/tag in trigger modal

* dont show labeling menu if no ML entities

* update "trigger phrases" tooltip for luis

* strings

* strings

Co-authored-by: Soroush <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Area: LU Belongs to LU feature area LU Editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants