This repository was archived by the owner on Jul 9, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 374
fix: Lu editing improvement fixes #6568
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
tdurnford
reviewed
Mar 25, 2021
tdurnford
approved these changes
Mar 25, 2021
| "message": "Apr 9, 2020" | ||
| }, | ||
| "are_you_sure_you_want_to_delete_your_bot_this_acti_214a9e11": { | ||
| "message": "Are you sure you want to delete your bot? This action cannot be undone and your bot and all related files in the bot project folder will be permanently deleted. Your Azure resources will remain unchanged." |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nit: I would have 4 sentences here:
Are you sure you want to delete your bot? This action cannot be undone. Your bot and all related files in the bot project folder will be permanently deleted. Your Azure resources will remain unchanged.
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GeoffCoxMSFT Out of curiosity, why would you opt for separate sentences?
GeoffCoxMSFT
approved these changes
Mar 25, 2021
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* enable insert/tag in trigger modal * dont show labeling menu if no ML entities * update "trigger phrases" tooltip for luis * strings * strings Co-authored-by: Soroush <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Task Item
#minor